Maven: infer pom packaging when cached BOM lacks explicit <packaging>#7536
Open
Jammy-Louie wants to merge 1 commit intomainfrom
Open
Maven: infer pom packaging when cached BOM lacks explicit <packaging>#7536Jammy-Louie wants to merge 1 commit intomainfrom
Jammy-Louie wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
When a cached POM in the local Maven repository declares no
<packaging>and has no JAR file alongside it, inferpompackaging if the POM has a non-empty<dependencyManagement>. This makes BOMs whose<packaging>pom</packaging>element is missing (e.g. stripped by a proxy or mirror during caching) resolve from the local cache instead of being silently discarded.What's your motivation?
Reported case:
org.jooq:jooq-bom:3.20.10was present in~/.m2but its cached POM lacked<packaging>pom</packaging>. OpenRewrite silently skipped the entry and fell through to a remote.Anything in particular you'd like reviewers to focus on?
The gating condition
!jarFileExists && !pom.getDependencyManagement().isEmpty(), chosen so that the inference only fires for POMs with an unmistakable BOM signal. A jar artifact that omits<packaging>(relying on Maven's jar default) and happens to have a missing local JAR will not be misidentified, since jar artifacts essentially never declare<dependencyManagement>.Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
<packaging>pom</packaging>to the cached POM file. Works per-artifact but doesn't generalize.Checklist